Skip to content

Commit 3bb68c2

Browse files
heschigopherbot
authored andcommitted
internal/task: don't check blockers for RC releases
I missed a quirk of logic in releasebot. For golang/go#51797. Change-Id: I8f1fd9f4af4ae6743d7d874b5223b45fd9127c96 Reviewed-on: https://go-review.googlesource.com/c/build/+/416219 Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Heschi Kreinick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Heschi Kreinick <[email protected]>
1 parent 8c4a1e1 commit 3bb68c2

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

internal/task/milestones.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,12 @@ func uppercaseVersion(version string) string {
8383
// CheckBlockers returns an error if there are open release blockers in
8484
// the current milestone.
8585
func (m *MilestoneTasks) CheckBlockers(ctx *workflow.TaskContext, milestones ReleaseMilestones, version string, kind ReleaseKind) error {
86+
if kind == KindRC {
87+
// We don't check blockers for release candidates; they're expected to
88+
// at least have recurring blockers, and we don't have an okay-after
89+
// label to suppress them.
90+
return nil
91+
}
8692
issues, err := m.loadMilestoneIssues(ctx, milestones.Current, kind)
8793
if err != nil {
8894
return err

0 commit comments

Comments
 (0)