dashboard, cmd/buildlet: add Windows XP builder

Updates golang/go#10267

Change-Id: I79064d9a2aca11bc14c73beef44d70098ed1ae3f
Reviewed-on: https://go-review.googlesource.com/83055
Reviewed-by: Brad Fitzpatrick <[email protected]>

Author: bradfitz

cmd/buildlet/Makefile

@@ -19,6 +19,7 @@ compile:
 	GOOS=linux GOARCH=s390x go install golang.org/x/build/cmd/buildlet
 	GOOS=darwin GOARCH=amd64 go install golang.org/x/build/cmd/buildlet
 	GOOS=windows GOARCH=amd64 go install golang.org/x/build/cmd/buildlet
+	GOOS=windows GOARCH=386 go install golang.org/x/build/cmd/buildlet
 	GOOS=freebsd GOARCH=amd64 go install golang.org/x/build/cmd/buildlet
 	GOOS=netbsd GOARCH=amd64 go install golang.org/x/build/cmd/buildlet
 	GOOS=openbsd GOARCH=amd64 go install golang.org/x/build/cmd/buildlet
@@ -70,6 +71,10 @@ buildlet.windows-amd64: FORCE buildlet_windows.go
 	go install golang.org/x/build/cmd/upload
 	upload --verbose --osarch=$@ --file=go:golang.org/x/build/cmd/buildlet --public --cacheable=false go-builder-data/$@
 
+buildlet.windows-386: FORCE buildlet_windows.go
+	go install golang.org/x/build/cmd/upload
+	upload --verbose --osarch=$@ --file=go:golang.org/x/build/cmd/buildlet --public --cacheable=false go-builder-data/$@
+
 buildlet.linux-arm: FORCE
 	go install golang.org/x/build/cmd/upload
 	upload --verbose --osarch=$@ --file=go:golang.org/x/build/cmd/buildlet --public --cacheable=false go-builder-data/$@

cmd/buildlet/stage0/stage0.go

@@ -164,6 +164,8 @@ Download:
 		cmd.Args = append(cmd.Args,
 			scalewayArgs...,
 		)
+	case "host-windows-386-xp":
+		cmd.Args = append(cmd.Args, reverseHostTypeArgs("host-windows-386-xp")...)
 	}
 	switch osArch {
 	case "linux/s390x":
@@ -299,8 +301,11 @@ func isNetworkUp() bool {
 }
 
 func buildletURL() string {
-	if os.Getenv("GO_BUILDER_ENV") == "linux-arm-arm5spacemonkey" {
+	switch os.Getenv("GO_BUILDER_ENV") {
+	case "linux-arm-arm5spacemonkey":
 		return "https://storage.googleapis.com/go-builder-data/buildlet.linux-arm-arm5"
+	case "host-windows-386-xp":
+		return "https://storage.googleapis.com/go-builder-data/buildlet.windows-386"
 	}
 	switch osArch {
 	case "linux/s390x":

dashboard/builders.go

@@ -254,6 +254,21 @@ var Hosts = map[string]*HostConfig{
 		goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/go1.4-windows-amd64.tar.gz",
 		SSHUsername:        "gopher",
 	},
+	// We only test Windows XP on 32-bit, because only less than
+	// 1% of XP users ever had 64-bit XP, according to numbers
+	// found online. And we test XP at all because it's the oldest
+	// Windows we claim to support, so let's see if it remains
+	// true, until we decide to not support it.
+	"host-windows-386-xp": &HostConfig{
+		Notes:       "VMware instance run by Brad. No cgo. XP SP3.",
+		OwnerGithub: "bradfitz",
+		IsReverse:   true,
+		ExpectNum:   1,
+		env: []string{
+			"CGO_ENABLED=0",
+			`GOROOT_BOOTSTRAP=C:\Documents and Settings\winxp\go1.4`,
+		},
+	},
 	"host-darwin-10_8": &HostConfig{
 		IsReverse: true,
 		ExpectNum: 1,
@@ -1170,6 +1185,11 @@ func init() {
 		Notes:    "Only runs -race tests (./race.bat)",
 		env:      []string{"GOARCH=amd64", "GOHOSTARCH=amd64"},
 	})
+	addBuilder(BuildConfig{
+		Name:      "windows-386-xp",
+		HostType:  "host-windows-386-xp",
+		MaxAtOnce: 1, // only one anyway
+	})
 	addBuilder(BuildConfig{
 		Name:              "darwin-amd64-10_8",
 		HostType:          "host-darwin-10_8",