internal/relui: update test's failing builder skip for Go 1.21

The "js-wasm" builder runs on Go 1.20 and older, so it failing and being
skipped during TestRelease was an elaborate no-op. It only had effect in
TestNonDistpack that still tests the 1.20 release branch.

Match the all.bash failure by GOOS rather than builder name, that should
be less brittle.

Change-Id: I762ef4cb43c4630bcda26f5d4c09e2d9f6ef9499
Reviewed-on: https://go-review.googlesource.com/c/build/+/504526
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>

Author: dmitshur

internal/relui/buildrelease_test.go

@@ -255,7 +255,12 @@ func testRelease(t *testing.T, prevTag string, major int, wantVersion string, ki
 	workflow.Output(wd, "Published Go version", v)
 
 	w, err := workflow.Start(wd, map[string]interface{}{
-		"Targets to skip testing (or 'all') (optional)":            []string{"js-wasm"},
+		"Targets to skip testing (or 'all') (optional)": []string{
+			// allScript is intentionally hardcoded to fail on GOOS=js
+			// and we confirm here that it's possible to skip that.
+			"js-wasm-node18", // Builder used on 1.21 and newer.
+			"js-wasm",        // Builder used on 1.20 and older.
+		},
 		"Ref from the private repository to build from (optional)": "",
 	})
 	if err != nil {
@@ -557,13 +562,13 @@ fi
 `
 
 // allScript pretends to be all.bash. It's hardcoded
-// to fail on js-wasm and pass on all other builders.
+// to fail on GOOS=js and pass on all other builders.
 const allScript = `#!/bin/bash -eu
 
 echo "I'm a test! :D"
 
-if [[ $GO_BUILDER_NAME = "js-wasm" ]]; then
-  echo "Oh no, WASM is broken"
+if [[ ${GOOS:-} = "js" ]]; then
+  echo "Oh no, JavaScript is broken."
   exit 1
 fi