Skip to content

Commit 6464c3e

Browse files
committed
cmd/coordinator: warn about known linux-arm SlowBot issue
The current linux-arm builder is known to have trouble when used as a SlowBot. Start warning about it when the builder is requested via the TRY= SlowBot UI. I've considered also removing or disabling the "arm" SlowBot alias, but that would make it easier to miss that there's an issue, since SlowBots don't warn about unknown builders: If you specify an unknown TRY= token, it'll just ignore it and won't report an error. We can consider making further changes as this situation evolves. The goal here is to start notifying about a known problem sooner. For golang/go#35628. For golang/go#40872. Change-Id: Ibc1205720c44ec4823c632c04fc2f887368258c1 Reviewed-on: https://go-review.googlesource.com/c/build/+/249420 Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
1 parent d77c6d0 commit 6464c3e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

cmd/coordinator/coordinator.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,6 +1383,14 @@ func (ts *trySet) notifyStarting() {
13831383
}
13841384
msg := name + " beginning. Status page: https://farmer.golang.org/try?commit=" + ts.Commit[:8]
13851385

1386+
// If any of the requested SlowBot builders
1387+
// have a known issue, give users a warning.
1388+
for _, b := range ts.slowBots {
1389+
if b.KnownIssue != 0 {
1390+
msg += fmt.Sprintf("\nNote that builder %s has a known issue golang.org/issue/%d.", b.Name, b.KnownIssue)
1391+
}
1392+
}
1393+
13861394
gerritClient := pool.NewGCEConfiguration().GerritClient()
13871395
ctx := context.Background()
13881396
if ci, err := gerritClient.GetChangeDetail(ctx, ts.ChangeTriple()); err == nil {

dashboard/builders.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1760,7 +1760,8 @@ func init() {
17601760
GOARM: "7",
17611761
AlwaysCrossCompile: false,
17621762
},
1763-
tryBot: nil, // Issue 22748, Issue 22749
1763+
tryBot: nil, // Issues #22748, #22749, #35628, #40872.
1764+
KnownIssue: 35628,
17641765
FlakyNet: true,
17651766
numTestHelpers: 2,
17661767
numTryTestHelpers: 7,

0 commit comments

Comments
 (0)