Skip to content

Commit 924bb6b

Browse files
johnsonjbroady
authored andcommitted
cmd/release: notify explorer of PATH update after install on Win
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is pending. This message is required for explorer.exe to reload the PATH from the registry so future cmd.exe processes will launch with go/bin in the PATH. Use the Wix extension to always broadcast this message after install. More info: http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.html Fixes golang/go#18680 Change-Id: I4f3af49f167f3875bbf8e898f4d50ee358b4e35d Reviewed-on: https://go-review.googlesource.com/36324 Reviewed-by: Chris Broadfoot <[email protected]>
1 parent 0979e53 commit 924bb6b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

cmd/release/releaselet.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -681,6 +681,9 @@ var windowsData = map[string]string{
681681
<Custom Action="SetApplicationRootDirectory" Before="InstallFinalize" />
682682
</InstallExecuteSequence>
683683
684+
<!-- Notify top level applications of the new PATH variable (golang.org/issue/18680) -->
685+
<CustomActionRef Id="WixBroadcastEnvironmentChange" />
686+
684687
<!-- Include the user interface -->
685688
<WixVariable Id="WixUILicenseRtf" Value="LICENSE.rtf" />
686689
<WixVariable Id="WixUIBannerBmp" Value="images\Banner.jpg" />

0 commit comments

Comments
 (0)