Skip to content

Commit a541ae4

Browse files
author
Bryan C. Mills
committed
devapp/owners: remove catchall entry for the 'go' repo
The owners table is consumed by gopherbot to assign reviewers and escalate triaged issues. Gopherbot has its own fallback behavior for unowned paths, which should generally be to escalate to whichever member of the Go team is on triage duty (or to escalate to the Go Open Source Project subteam in general to update the owners table). Due to the explicit entry for the root of the 'go' repository, when gopherbot encounters an issue or CL for any standard-library package without an owner, it will instead escalate to rsc, ianlancetaylor, and bradfitz. That doesn't seem like a great use of their time, and also masks the missing entry in the owners table. This CL removes that top-level entry, so that unknown paths within the Go repo will appear to gopherbot as such. Updates golang/go#27586 Change-Id: I469028f7ec5f4b357ae33bca125da2323fc3e0d2 Reviewed-on: https://go-review.googlesource.com/c/build/+/171358 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Andrew Bonventre <[email protected]>
1 parent e95584b commit a541ae4

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

devapp/owners/owners_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,7 @@ func TestMatch(t *testing.T) {
4747
},
4848
},
4949
{
50-
"go/path/with/no/owners",
51-
&Entry{
52-
Primary: []Owner{rsc, iant, bradfitz},
53-
},
50+
"go/path/with/no/owners", nil,
5451
},
5552
{
5653
"nonexistentrepo/foo/bar", nil,

devapp/owners/table.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,6 @@ var entries = map[string]*Entry{
8787
Secondary: []Owner{filippo},
8888
},
8989

90-
"go": {
91-
Primary: []Owner{rsc, iant, bradfitz},
92-
},
9390
"go/src/archive/tar": {
9491
Primary: []Owner{joetsai},
9592
},

0 commit comments

Comments
 (0)