Skip to content

Commit eb52e71

Browse files
committed
dashboard, cmd/coordinator: add concept of trybot-only builders
Make all-compiler a trybot-only builder. This will be used for temporary sharded ARM trybots. Updates golang/go#10029 Change-Id: I6cc3188887c2f24edef97d0a9354e39553a15896 Reviewed-on: https://go-review.googlesource.com/10051 Reviewed-by: Andrew Gerrand <[email protected]>
1 parent 46d9b00 commit eb52e71

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

cmd/coordinator/coordinator.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,8 +569,8 @@ func findWork(work chan<- builderRev) error {
569569
continue
570570
}
571571
builder := bs.Builders[i]
572-
if _, ok := dashboard.Builders[builder]; !ok {
573-
// Not managed by the coordinator.
572+
if builderInfo, ok := dashboard.Builders[builder]; !ok || builderInfo.TryOnly {
573+
// Not managed by the coordinator, or a trybot-only one.
574574
continue
575575
}
576576
br := builderRev{bs.Builders[i], br.Revision}
@@ -582,8 +582,8 @@ func findWork(work chan<- builderRev) error {
582582

583583
// And to bootstrap new builders, see if we have any builders
584584
// that the dashboard doesn't know about.
585-
for b := range dashboard.Builders {
586-
if knownToDashboard[b] {
585+
for b, builderInfo := range dashboard.Builders {
586+
if builderInfo.TryOnly || knownToDashboard[b] {
587587
continue
588588
}
589589
for _, rev := range goRevisions {

dashboard/builders.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ type BuildConfig struct {
2828

2929
IsReverse bool // if true, only use the reverse buildlet pool
3030
RegularDisk bool // if true, use spinning disk instead of SSD
31+
TryOnly bool // only used for trybots, and not regular builds
3132

3233
env []string // extra environment ("key=value") pairs
3334
}
@@ -184,6 +185,7 @@ func init() {
184185
})
185186
addBuilder(BuildConfig{
186187
Name: "all-compile",
188+
TryOnly: true, // TODO: for speed, restrict this to builds not covered by other trybots
187189
VMImage: "linux-buildlet-std",
188190
machineType: "n1-highcpu-16", // CPU-bound, uses it well.
189191
Notes: "Runs buildall.sh to compile stdlib for all GOOS/GOARCH, but doesn't run any tests.",

0 commit comments

Comments
 (0)