Skip to content

Commit f9ec3ca

Browse files
committed
dashboard: add compile-only TryBot coverage for windows/arm64 port
The windows/arm64 port has been completed in golang.org/issue/36439 recently. Add pre-submit compile-only coverage via a misc-compile TryBot for the new port. It can be upgraded to a normal TryBot that also executes tests after a windows/arm64 builder becomes available. Tested locally by running 'buildall.bash windows-arm64' on a recent Go tip commit (CL 313849), which passed. For golang/go#36439. Updates golang/go#42604. Change-Id: Ie4988a876aa18392a583eb407c6c3621eb30a4f8 Reviewed-on: https://go-review.googlesource.com/c/build/+/314430 Trust: Dmitri Shuralyov <[email protected]> Trust: Alexander Rakoczy <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
1 parent 2b6edb4 commit f9ec3ca

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

dashboard/builders.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1651,7 +1651,7 @@ func init() {
16511651
// some misc-compile TryBot could become much slower than others.)
16521652
//
16531653
// See golang.org/issue/32632.
1654-
addMiscCompile("-mac-win", "darwin-amd64", "windows-arm")
1654+
addMiscCompile("-mac-win", "darwin-amd64", "windows-arm", "windows-arm64")
16551655
addMiscCompileGo1(16, "-darwinarm64", "darwin-arm64") // darwin/arm64 (for Go 1.16 and newer) only.
16561656
addMiscCompile("-mips", "linux-mips", "linux-mips64")
16571657
addMiscCompile("-mipsle", "linux-mipsle", "linux-mips64le")

dashboard/builders_test.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -843,12 +843,10 @@ func TestTryBotsCompileAllPorts(t *testing.T) {
843843
// knownMissing tracks Go ports that that are known to be
844844
// completely missing TryBot (pre-submit) test coverage.
845845
//
846-
// All ports should have either a real TryBot or at least a misc-compile TryBot,
846+
// All completed ports should have either a real TryBot or at least a misc-compile TryBot,
847847
// so this map is meant to be used to temporarily fix tests
848848
// when the work of adding a new port is actively underway.
849-
knownMissing := map[string]bool{
850-
"windows-arm64": true, // TODO(golang.org/issue/42604): Add builder for windows/arm64.
851-
}
849+
knownMissing := map[string]bool{}
852850

853851
var done = make(map[string]bool)
854852
check := func(goos, goarch string) {

0 commit comments

Comments
 (0)