Skip to content

Commit 040607a

Browse files
authored
strings.TrimSpace micro-optimization
strings.TrimSpace string's end final trimming should use more specific TrimRightFunc instead of common TrimFunc (because start has already trimmed before)
1 parent 3f9ec83 commit 040607a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/strings/strings.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,8 @@ func TrimSpace(s string) string {
884884
for ; stop > start; stop-- {
885885
c := s[stop-1]
886886
if c >= utf8.RuneSelf {
887-
return TrimFunc(s[start:stop], unicode.IsSpace)
887+
// start has been already trimmed above, should trim end only
888+
return TrimRightFunc(s[start:stop], unicode.IsSpace)
888889
}
889890
if asciiSpace[c] == 0 {
890891
break

0 commit comments

Comments
 (0)