Skip to content

Commit 0670afa

Browse files
author
Bryan C. Mills
committed
doc/go1.19: move the description of the runtime.GOROOT change from 'cmd/go' to 'runtime'
Even though the change in the behavior of 'runtime.GOROOT' was not actually due to a change in the runtime package proper, I suspect that users who notice it will look for the release note in that section, not the 'cmd/go' section. Fixes #51461. Change-Id: I271752968d4152a7fdf3e170537e3072bf87ce86 Reviewed-on: https://go-review.googlesource.com/c/go/+/400814 Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent e042808 commit 0670afa

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

doc/go1.19.html

+11-5
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ <h3 id="go-command">Go command</h3>
3636
</p>
3737

3838
<!-- https://go.dev/issue/51461 -->
39-
<p>
40-
Passing the <code>-trimpath</code> flag to <code>go</code> commands now
41-
causes <code>runtime.GOROOT()</code> in the resulting binary to return the
42-
empty string instead of the string <code>"go"</code>.
43-
</p>
4439
<p>
4540
The <code>-trimpath</code> flag, if set, is now included in the build settings
4641
stamped into Go binaries by <code>go</code> <code>build</code>, and can be
@@ -137,6 +132,17 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
137132
</dd>
138133
</dl><!-- net -->
139134

135+
<dl id="runtime"><dt><a href="/pkg/runtime/">runtime</a></dt>
136+
<dd>
137+
<p><!-- https://go.dev/issue/51461 -->
138+
The <code>GOROOT</code> function now returns the empty string
139+
(instead of <code>"go"</code>) when the binary was built with
140+
the <code>-trimpath</code> flag set and the <code>GOROOT</code>
141+
variable is not set in the process environment.
142+
</p>
143+
</dd>
144+
</dl><!-- runtime -->
145+
140146
<dl id="strconv"><dt><a href="/pkg/strconv/">strconv</a></dt>
141147
<dd>
142148
<p><!-- CL 397255 -->

0 commit comments

Comments
 (0)