Make logic in security check more robust, make tests more realistic.

Author: witchard

src/cmd/go/internal/get/get.go

@@ -475,7 +475,7 @@ func downloadPackage(p *load.Package) error {
 		}
 		vcs, repo, rootPath = rr.vcs, rr.Repo, rr.Root
 	}
-	if !blindRepo && !vcs.isSecure(repo) && security == web.SecureOnly {
+	if !blindRepo && !vcs.isSecure(repo) && security != web.Insecure {
 		return fmt.Errorf("cannot download, %v uses insecure protocol", repo)
 	}
 

src/cmd/go/testdata/script/get_insecure_env.txt

@@ -20,7 +20,7 @@ env GOINSECURE=
 ! go get -d -u -f insecure.go-get-issue-15410.appspot.com/pkg/p
 
 # GOPATH: Try updating with GOINSECURE glob (should succeed).
-env GOINSECURE=insecure.go-get-*
+env GOINSECURE=*.go-get-*.appspot.com
 go get -d -u -f insecure.go-get-issue-15410.appspot.com/pkg/p
 
 # GOPATH: Try updating with GOINSECURE base URL (should succeed).