Skip to content

Commit 08725f9

Browse files
FiloSottilegopherbot
authored andcommitted
crypto/internal/cryptotest: skip TestAllocations on s390x
TestXAESAllocations fails like #70448, and crypto/rand's fails in FIPS mode. We can't keep chasing these without even a LUCI builder. Updates #67307 Change-Id: I5d0edddf470180a321dec55cabfb018db62eb940 Reviewed-on: https://go-review.googlesource.com/c/go/+/636055 Auto-Submit: Filippo Valsorda <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent 1cbfe8c commit 08725f9

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/crypto/internal/cryptotest/allocations.go

+6
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ func SkipTestAllocations(t *testing.T) {
3232
t.Skip("skipping allocations test on plan9")
3333
}
3434

35+
// s390x deviates from other assembly implementations and is very hard to
36+
// test due to the lack of LUCI builders. See #67307.
37+
if runtime.GOARCH == "s390x" {
38+
t.Skip("skipping allocations test on s390x")
39+
}
40+
3541
// Some APIs rely on inliner and devirtualization to allocate on the stack.
3642
testenv.SkipIfOptimizationOff(t)
3743
}

0 commit comments

Comments
 (0)