Skip to content

Commit 1dee637

Browse files
cuiweixiepull[bot]
authored andcommitted
net: use strings.Builder
Change-Id: I3861a73d6b9d1d454c42bec50099b916bf30f1cd Reviewed-on: https://go-review.googlesource.com/c/go/+/428266 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Robert Griesemer <[email protected]> Run-TryBot: xie cui <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Damien Neil <[email protected]>
1 parent 26ea625 commit 1dee637

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/net/lookup_test.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
package net
88

99
import (
10-
"bytes"
1110
"context"
1211
"fmt"
1312
"internal/testenv"
@@ -718,7 +717,7 @@ func testDots(t *testing.T, mode string) {
718717
}
719718

720719
func mxString(mxs []*MX) string {
721-
var buf bytes.Buffer
720+
var buf strings.Builder
722721
sep := ""
723722
fmt.Fprintf(&buf, "[")
724723
for _, mx := range mxs {
@@ -730,7 +729,7 @@ func mxString(mxs []*MX) string {
730729
}
731730

732731
func nsString(nss []*NS) string {
733-
var buf bytes.Buffer
732+
var buf strings.Builder
734733
sep := ""
735734
fmt.Fprintf(&buf, "[")
736735
for _, ns := range nss {
@@ -742,7 +741,7 @@ func nsString(nss []*NS) string {
742741
}
743742

744743
func srvString(srvs []*SRV) string {
745-
var buf bytes.Buffer
744+
var buf strings.Builder
746745
sep := ""
747746
fmt.Fprintf(&buf, "[")
748747
for _, srv := range srvs {

src/net/lookup_windows_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
package net
66

77
import (
8-
"bytes"
98
"context"
109
"encoding/json"
1110
"errors"
@@ -216,8 +215,8 @@ func (s byHost) Less(i, j int) bool { return s[i].Host < s[j].Host }
216215
func (s byHost) Swap(i, j int) { s[i], s[j] = s[j], s[i] }
217216

218217
func nslookup(qtype, name string) (string, error) {
219-
var out bytes.Buffer
220-
var err bytes.Buffer
218+
var out strings.Builder
219+
var err strings.Builder
221220
cmd := exec.Command("nslookup", "-querytype="+qtype, name)
222221
cmd.Stdout = &out
223222
cmd.Stderr = &err

0 commit comments

Comments
 (0)