Skip to content

Commit 23173fc

Browse files
committed
net/http/httptrace: clarify ClientTrace docs
The old wording over-promised. Fixes #16957 Change-Id: Iaac04de0d24eb17a0db66beeeab9de70d0f6d391 Reviewed-on: https://go-review.googlesource.com/31735 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Tom Bergan <[email protected]>
1 parent f0e347b commit 23173fc

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/net/http/httptrace/trace.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,8 @@ func WithClientTrace(ctx context.Context, trace *ClientTrace) context.Context {
6868

6969
// ClientTrace is a set of hooks to run at various stages of an outgoing
7070
// HTTP request. Any particular hook may be nil. Functions may be
71-
// called concurrently from different goroutines, starting after the
72-
// call to Transport.RoundTrip and ending either when RoundTrip
73-
// returns an error, or when the Response.Body is closed.
71+
// called concurrently from different goroutines and some may be called
72+
// after the request has completed or failed.
7473
type ClientTrace struct {
7574
// GetConn is called before a connection is created or
7675
// retrieved from an idle pool. The hostPort is the

0 commit comments

Comments
 (0)