Skip to content

Commit 28ec966

Browse files
committed
adjust test
1 parent 312d27d commit 28ec966

File tree

2 files changed

+24
-22
lines changed

2 files changed

+24
-22
lines changed

src/debug/elf/elf_test.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -47,25 +47,3 @@ func TestNames(t *testing.T) {
4747
}
4848
}
4949
}
50-
51-
func TestNobitsSection(t *testing.T) {
52-
const testdata = "testdata/gcc-amd64-linux-exec"
53-
f, err := Open(testdata)
54-
if err != nil {
55-
t.Fatalf("could not read %s: %v", testdata, err)
56-
}
57-
defer f.Close()
58-
bss := f.Section(".bss")
59-
bssData, err := bss.Data()
60-
if err != nil {
61-
t.Fatalf("error reading .bss section: %v", err)
62-
}
63-
if g, w := uint64(len(bssData)), bss.Size; g != w {
64-
t.Errorf(".bss section length mismatch: got %d, want %d", g, w)
65-
}
66-
for i := range bssData {
67-
if bssData[i] != 0 {
68-
t.Fatalf("unexpected non-zero byte at offset %d: %#x", i, bssData[i])
69-
}
70-
}
71-
}

src/debug/elf/file_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -944,6 +944,30 @@ func TestNoSectionOverlaps(t *testing.T) {
944944
}
945945
}
946946

947+
func TestNobitsSection(t *testing.T) {
948+
const testdata = "testdata/gcc-amd64-linux-exec"
949+
f, err := Open(testdata)
950+
if err != nil {
951+
t.Fatalf("could not read %s: %v", testdata, err)
952+
}
953+
defer f.Close()
954+
955+
wantError := "unexpected read from SHT_NOBITS section"
956+
bss := f.Section(".bss")
957+
958+
_, err = bss.Data()
959+
if err == nil || err.Error() != wantError {
960+
t.Fatalf("bss.Data() got error %q, want error %q", err, wantError)
961+
}
962+
963+
r := bss.Open()
964+
p := make([]byte, 1)
965+
_, err = r.Read(p)
966+
if err == nil || err.Error() != wantError {
967+
t.Fatalf("r.Read(p) got error %q, want error %q", err, wantError)
968+
}
969+
}
970+
947971
func TestIssue10996(t *testing.T) {
948972
data := []byte("\u007fELF\x02\x01\x010000000000000" +
949973
"\x010000000000000000000" +

0 commit comments

Comments
 (0)