go/types, types2: remove duplicate resolve call

griesemer · griesemer · commit 2f87b9c94236 · 2021-09-21T00:26:53.000Z
Change-Id: I8afe8bf6304b6a3645bbd8d4d19f152862c58725 Reviewed-on: https://go-review.googlesource.com/c/go/+/351119 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Go Bot <gobot@golang.org>
diff --git a/src/cmd/compile/internal/types2/subst.go b/src/cmd/compile/internal/types2/subst.go
@@ -224,7 +224,6 @@ func (subst *subster) typ(typ Type) Type {
 			return named
 		}
 
-		t.orig.resolve(subst.env)
 		// Create a new instance and populate the environment to avoid endless
 		// recursion. The position used here is irrelevant because validation only
 		// occurs on t (we don't call validType on named), but we use subst.pos to
diff --git a/src/go/types/subst.go b/src/go/types/subst.go
@@ -210,7 +210,6 @@ func (subst *subster) typ(typ Type) Type {
 			return named
 		}
 
-		t.orig.resolve(subst.env)
 		// Create a new instance and populate the environment to avoid endless
 		// recursion. The position used here is irrelevant because validation only
 		// occurs on t (we don't call validType on named), but we use subst.pos to

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,6 @@ func (subst *subster) typ(typ Type) Type {`
`224`	`224`	`return named`
`225`	`225`	`}`
`226`	`226`
`227`		`- t.orig.resolve(subst.env)`
`228`	`227`	`// Create a new instance and populate the environment to avoid endless`
`229`	`228`	`// recursion. The position used here is irrelevant because validation only`
`230`	`229`	`// occurs on t (we don't call validType on named), but we use subst.pos to`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,6 @@ func (subst *subster) typ(typ Type) Type {`
`210`	`210`	`return named`
`211`	`211`	`}`
`212`	`212`
`213`		`- t.orig.resolve(subst.env)`
`214`	`213`	`// Create a new instance and populate the environment to avoid endless`
`215`	`214`	`// recursion. The position used here is irrelevant because validation only`
`216`	`215`	`// occurs on t (we don't call validType on named), but we use subst.pos to`