Skip to content

Commit 3d5e3a1

Browse files
perilloianlancetaylor
authored andcommitted
debug/pe: replace os.MkdirTemp with T.TempDir
Updates #45402 Change-Id: I3d83a66270ca38e82d6bb7f8a1367af3d5343a98 Reviewed-on: https://go-review.googlesource.com/c/go/+/309352 Trust: Tobias Klauser <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent c27991b commit 3d5e3a1

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

src/debug/pe/file_test.go

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -353,11 +353,7 @@ func testDWARF(t *testing.T, linktype int) {
353353
}
354354
testenv.MustHaveGoRun(t)
355355

356-
tmpdir, err := os.MkdirTemp("", "TestDWARF")
357-
if err != nil {
358-
t.Fatal(err)
359-
}
360-
defer os.RemoveAll(tmpdir)
356+
tmpdir := t.TempDir()
361357

362358
src := filepath.Join(tmpdir, "a.go")
363359
file, err := os.Create(src)
@@ -472,11 +468,7 @@ func TestBSSHasZeros(t *testing.T) {
472468
t.Skip("skipping test: gcc is missing")
473469
}
474470

475-
tmpdir, err := os.MkdirTemp("", "TestBSSHasZeros")
476-
if err != nil {
477-
t.Fatal(err)
478-
}
479-
defer os.RemoveAll(tmpdir)
471+
tmpdir := t.TempDir()
480472

481473
srcpath := filepath.Join(tmpdir, "a.c")
482474
src := `
@@ -596,15 +588,10 @@ func TestBuildingWindowsGUI(t *testing.T) {
596588
if runtime.GOOS != "windows" {
597589
t.Skip("skipping windows only test")
598590
}
599-
tmpdir, err := os.MkdirTemp("", "TestBuildingWindowsGUI")
600-
if err != nil {
601-
t.Fatal(err)
602-
}
603-
defer os.RemoveAll(tmpdir)
591+
tmpdir := t.TempDir()
604592

605593
src := filepath.Join(tmpdir, "a.go")
606-
err = os.WriteFile(src, []byte(`package main; func main() {}`), 0644)
607-
if err != nil {
594+
if err := os.WriteFile(src, []byte(`package main; func main() {}`), 0644); err != nil {
608595
t.Fatal(err)
609596
}
610597
exe := filepath.Join(tmpdir, "a.exe")

0 commit comments

Comments
 (0)