Skip to content

Commit 4469557

Browse files
author
Bryan C. Mills
committed
net/http/pprof: skip TestDeltaProfile on all arm and arm64 architectures
Given that we have seen failures with the same failure mode on both openbsd/arm and android/arm64, it seems likely that the underlying bug affects at least all ARM-based architectures. It appears that either these architectures are not able to sample at the frequency expected by the test, or the samples are for some reason being dropped. For #50218 Change-Id: I42a6c8ecda57448f8068e8facb42a4a2cecbbb37 Reviewed-on: https://go-review.googlesource.com/c/go/+/383997 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
1 parent dbbe4cc commit 4469557

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/net/http/pprof/pprof_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func mutexHog(duration time.Duration, hogger func(mu1, mu2 *sync.Mutex, start ti
153153
}
154154

155155
func TestDeltaProfile(t *testing.T) {
156-
if runtime.GOOS == "openbsd" && runtime.GOARCH == "arm" {
156+
if strings.HasPrefix(runtime.GOARCH, "arm") {
157157
testenv.SkipFlaky(t, 50218)
158158
}
159159

0 commit comments

Comments
 (0)