go/types: update test case to exercise mutually recursive interfaces

findleyr · findleyr · commit 494ec85d9fd6 · 2020-08-24T16:41:53.000Z
Due to a typo, this test case was not actually exercising the bug described in #33656. Update it to do so. Interestingly, the comparison is now valid (as it should be) -- I suspect #33656 is actually fixed. Fixes #33656 Change-Id: If50a917f6477d8eb4f82f5a2a96bf5d9123ff0d4 Reviewed-on: https://go-review.googlesource.com/c/go/+/241263 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
diff --git a/src/go/types/testdata/cycles2.src b/src/go/types/testdata/cycles2.src
@@ -37,7 +37,7 @@ type A interface {
 }
 
 type B interface {
-	a() interface {
+	b() interface {
 		AB
 	}
 }
@@ -59,8 +59,7 @@ var y interface {
 	B
 }
 
-// TODO(gri) This should be a valid compare. See #33656.
-var _ = x /* ERROR cannot compare */ == y
+var _ = x == y
 
 
 // Test case for issue 6638.

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ type A interface {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`type B interface {`
`40`		`- a() interface {`
	`40`	`+ b() interface {`
`41`	`41`	`AB`
`42`	`42`	`}`
`43`	`43`	`}`
`@@ -59,8 +59,7 @@ var y interface {`
`59`	`59`	`B`
`60`	`60`	`}`
`61`	`61`
`62`		`-// TODO(gri) This should be a valid compare. See #33656.`
`63`		`-var _ = x /* ERROR cannot compare */ == y`
	`62`	`+var _ = x == y`
`64`	`63`
`65`	`64`
`66`	`65`	`// Test case for issue 6638.`