Skip to content

Commit 4cffe2b

Browse files
Elias Naurbradfitz
Elias Naur
authored andcommitted
cmd/dist: use the target GOOS to skip the test for issue 18153
Fixes (skips) the test on Android, where stdout/stderr are not terminals. Updates #18153 Change-Id: Ieca65150362a5c423747ad751e00f76f0b890746 Reviewed-on: https://go-review.googlesource.com/35957 Run-TryBot: Elias Naur <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 6bdb0c1 commit 4cffe2b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/cmd/dist/test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"os/exec"
1616
"path/filepath"
1717
"regexp"
18-
"runtime"
1918
"strconv"
2019
"strings"
2120
"sync"
@@ -354,7 +353,7 @@ func (t *tester) registerTests() {
354353

355354
// This test needs its stdout/stderr to be terminals, so we don't run it from cmd/go's tests.
356355
// See issue 18153.
357-
if runtime.GOOS == "linux" {
356+
if t.goos == "linux" {
358357
t.tests = append(t.tests, distTest{
359358
name: "cmd_go_test_terminal",
360359
heading: "cmd/go terminal test",

0 commit comments

Comments
 (0)