Skip to content

Commit 5d5f779

Browse files
ianwoolfodeke-em
authored andcommitted
net/http: replace os.MkdirTemp with T.TempDir
Updates: #45402 Change-Id: Ia61f422d058bf57fc3688abc25597d6cc1692c51 Reviewed-on: https://go-review.googlesource.com/c/go/+/307653 Run-TryBot: Dave Cheney <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Dave Cheney <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
1 parent 4bbe046 commit 5d5f779

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/net/http/filetransport_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ func checker(t *testing.T) func(string, error) {
2323
func TestFileTransport(t *testing.T) {
2424
check := checker(t)
2525

26-
dname, err := os.MkdirTemp("", "")
27-
check("TempDir", err)
26+
dname := t.TempDir()
2827
fname := filepath.Join(dname, "foo.txt")
29-
err = os.WriteFile(fname, []byte("Bar"), 0644)
28+
err := os.WriteFile(fname, []byte("Bar"), 0644)
3029
check("WriteFile", err)
31-
defer os.Remove(dname)
3230
defer os.Remove(fname)
3331

3432
tr := &Transport{}

src/net/http/fs_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -378,11 +378,7 @@ func mustRemoveAll(dir string) {
378378

379379
func TestFileServerImplicitLeadingSlash(t *testing.T) {
380380
defer afterTest(t)
381-
tempDir, err := os.MkdirTemp("", "")
382-
if err != nil {
383-
t.Fatalf("TempDir: %v", err)
384-
}
385-
defer mustRemoveAll(tempDir)
381+
tempDir := t.TempDir()
386382
if err := os.WriteFile(filepath.Join(tempDir, "foo.txt"), []byte("Hello world"), 0644); err != nil {
387383
t.Fatalf("WriteFile: %v", err)
388384
}

0 commit comments

Comments
 (0)