Skip to content

Commit 5e3008f

Browse files
committed
runtime: move linux specific code into linux specific files
Allows us to stop whitelisting this error on many OS/arch combinations
1 parent 090034c commit 5e3008f

11 files changed

+6
-19
lines changed

src/cmd/vet/all/whitelist/darwin_arm.txt

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/cmd/vet/all/whitelist/darwin_arm64.txt

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
// freebsd/arm-specific vet whitelist. See readme.txt for details.
22

3-
runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
43
runtime/sys_freebsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// nacl/arm-specific vet whitelist. See readme.txt for details.
22

3-
runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
43
runtime/sys_nacl_arm.s: [arm] nacl_clock_gettime: function nacl_clock_gettime missing Go declaration
54
runtime/sys_nacl_arm.s: [arm] nacl_sysinfo: function nacl_sysinfo missing Go declaration
65
runtime/sys_nacl_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// netbsd/arm-specific vet whitelist. See readme.txt for details.
22

3-
runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
43
runtime/sys_netbsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration
54
syscall/asm_netbsd_arm.s: [arm] Syscall9: unknown variable trap; offset 0 is num+0(FP)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
// openbsd/arm-specific vet whitelist. See readme.txt for details.
22

3-
runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
43
runtime/sys_openbsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
// plan9/arm-specific vet whitelist. See readme.txt for details.
22

3-
runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
43
runtime/sys_plan9_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration

src/runtime/asm_arm.s

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -891,9 +891,6 @@ TEXT runtime·usplitR0(SB),NOSPLIT,$0
891891
SUB R1, R3, R1
892892
RET
893893

894-
TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
895-
RET
896-
897894
#ifndef GOOS_nacl
898895
// This is called from .init_array and follows the platform, not Go, ABI.
899896
TEXT runtime·addmoduledata(SB),NOSPLIT,$0-8

src/runtime/asm_arm64.s

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,9 +1128,6 @@ TEXT runtime·goexit(SB),NOSPLIT|NOFRAME|TOPFRAME,$0-0
11281128
MOVD R0, R0 // NOP
11291129
BL runtime·goexit1(SB) // does not return
11301130

1131-
TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
1132-
RET
1133-
11341131
// This is called from .init_array and follows the platform, not Go, ABI.
11351132
TEXT runtime·addmoduledata(SB),NOSPLIT,$0-0
11361133
SUB $0x10, RSP

src/runtime/sys_linux_arm.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,3 +606,6 @@ TEXT runtime·sbrk0(SB),NOSPLIT,$0-4
606606
SWI $0
607607
MOVW R0, ret+0(FP)
608608
RET
609+
610+
TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
611+
RET

src/runtime/sys_linux_arm64.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -599,3 +599,6 @@ TEXT runtime·sbrk0(SB),NOSPLIT,$0-8
599599
SVC
600600
MOVD R0, ret+0(FP)
601601
RET
602+
603+
TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
604+
RET

0 commit comments

Comments
 (0)