Skip to content

Commit 724638c

Browse files
martischrsc
authored andcommitted
[release-branch.go1.9] crypto/x509: skip TestSystemRoots
golang.org/cl/36941 enabled loading of all trusted certs on darwin for the non-cgo execSecurityRoots. The corresponding cgo version golang.org/cl/36942 for systemRootsPool has not been merged yet. This tests fails reliably on some darwin systems: --- FAIL: TestSystemRoots (1.28s) root_darwin_test.go:31: cgo sys roots: 353.552363ms root_darwin_test.go:32: non-cgo sys roots: 921.85297ms root_darwin_test.go:44: got 169 roots root_darwin_test.go:44: got 455 roots root_darwin_test.go:73: insufficient overlap between cgo and non-cgo roots; want at least 227, have 168 FAIL FAIL crypto/x509 2.445s Updates #16532 Updates #21416 Change-Id: I52c2c847651fb3621fdb6ab858ebe8e28894c201 Reviewed-on: https://go-review.googlesource.com/57830 Run-TryBot: Martin Möhrmann <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Joe Tsai <[email protected]> Reviewed-on: https://go-review.googlesource.com/70847 Run-TryBot: Russ Cox <[email protected]> Reviewed-by: Martin Möhrmann <[email protected]>
1 parent ed3b0d6 commit 724638c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/crypto/x509/root_darwin_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ func TestSystemRoots(t *testing.T) {
1616
t.Skipf("skipping on %s/%s, no system root", runtime.GOOS, runtime.GOARCH)
1717
}
1818

19+
switch runtime.GOOS {
20+
case "darwin":
21+
t.Skipf("skipping on %s/%s until cgo part of golang.org/issue/16532 has been implemented.", runtime.GOOS, runtime.GOARCH)
22+
}
23+
1924
t0 := time.Now()
2025
sysRoots := systemRootsPool() // actual system roots
2126
sysRootsDuration := time.Since(t0)

0 commit comments

Comments
 (0)