Skip to content

Commit 73b0d84

Browse files
committed
net/http: temporarily disable the failing tests on Plan 9
Update #7237 LGTM=bradfitz R=jas, bradfitz CC=golang-codereviews https://golang.org/cl/57190045
1 parent e48751e commit 73b0d84

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

src/pkg/net/http/serve_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,9 @@ func TestMuxRedirectLeadingSlashes(t *testing.T) {
441441
}
442442

443443
func TestServerTimeouts(t *testing.T) {
444+
if runtime.GOOS == "plan9" {
445+
t.Skip("skipping test; see http://golang.org/issue/7237")
446+
}
444447
defer afterTest(t)
445448
reqNum := 0
446449
ts := httptest.NewUnstartedServer(HandlerFunc(func(res ResponseWriter, req *Request) {
@@ -517,6 +520,9 @@ func TestServerTimeouts(t *testing.T) {
517520
// shouldn't cause a handler to block forever on reads (next HTTP
518521
// request) that will never happen.
519522
func TestOnlyWriteTimeout(t *testing.T) {
523+
if runtime.GOOS == "plan9" {
524+
t.Skip("skipping test; see http://golang.org/issue/7237")
525+
}
520526
defer afterTest(t)
521527
var conn net.Conn
522528
var afterTimeoutErrc = make(chan error, 1)
@@ -840,6 +846,9 @@ func TestHeadResponses(t *testing.T) {
840846
}
841847

842848
func TestTLSHandshakeTimeout(t *testing.T) {
849+
if runtime.GOOS == "plan9" {
850+
t.Skip("skipping test; see http://golang.org/issue/7237")
851+
}
843852
defer afterTest(t)
844853
ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))
845854
ts.Config.ReadTimeout = 250 * time.Millisecond
@@ -1414,6 +1423,9 @@ func TestRequestBodyLimit(t *testing.T) {
14141423
// TestClientWriteShutdown tests that if the client shuts down the write
14151424
// side of their TCP connection, the server doesn't send a 400 Bad Request.
14161425
func TestClientWriteShutdown(t *testing.T) {
1426+
if runtime.GOOS == "plan9" {
1427+
t.Skip("skipping test; see http://golang.org/issue/7237")
1428+
}
14171429
defer afterTest(t)
14181430
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))
14191431
defer ts.Close()

src/pkg/net/http/transport_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,9 @@ func TestTransportGzipRecursive(t *testing.T) {
793793

794794
// tests that persistent goroutine connections shut down when no longer desired.
795795
func TestTransportPersistConnLeak(t *testing.T) {
796+
if runtime.GOOS == "plan9" {
797+
t.Skip("skipping test; see http://golang.org/issue/7237")
798+
}
796799
defer afterTest(t)
797800
gotReqCh := make(chan bool)
798801
unblockCh := make(chan bool)
@@ -859,6 +862,9 @@ func TestTransportPersistConnLeak(t *testing.T) {
859862
// golang.org/issue/4531: Transport leaks goroutines when
860863
// request.ContentLength is explicitly short
861864
func TestTransportPersistConnLeakShortBody(t *testing.T) {
865+
if runtime.GOOS == "plan9" {
866+
t.Skip("skipping test; see http://golang.org/issue/7237")
867+
}
862868
defer afterTest(t)
863869
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
864870
}))
@@ -1066,6 +1072,9 @@ func TestTransportConcurrency(t *testing.T) {
10661072
}
10671073

10681074
func TestIssue4191_InfiniteGetTimeout(t *testing.T) {
1075+
if runtime.GOOS == "plan9" {
1076+
t.Skip("skipping test; see http://golang.org/issue/7237")
1077+
}
10691078
defer afterTest(t)
10701079
const debug = false
10711080
mux := NewServeMux()
@@ -1127,6 +1136,9 @@ func TestIssue4191_InfiniteGetTimeout(t *testing.T) {
11271136
}
11281137

11291138
func TestIssue4191_InfiniteGetToPutTimeout(t *testing.T) {
1139+
if runtime.GOOS == "plan9" {
1140+
t.Skip("skipping test; see http://golang.org/issue/7237")
1141+
}
11301142
defer afterTest(t)
11311143
const debug = false
11321144
mux := NewServeMux()

0 commit comments

Comments
 (0)