Skip to content

Commit 78b4518

Browse files
author
Bryan C. Mills
committed
crypto/x509: skip known TestSystemVerify flakes on windows-*-2008 builders
The "-2008" builders are the only ones on which the failure has been observed, so I suspect that it is due to a platform bug fixed in a subsequent release. Since no one has added a workaround since #19564 was filed over four years ago, I'm assuming that no workaround is planned for this issue. Let's add a skip for the known failure mode and call it at that. Fixes #19564 Change-Id: Iefc22d1cc78bfdc79c845eb60cac22e26caf388c Reviewed-on: https://go-review.googlesource.com/c/go/+/370377 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]>
1 parent 307d7c6 commit 78b4518

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/crypto/x509/verify_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"encoding/pem"
1414
"errors"
1515
"fmt"
16+
"internal/testenv"
1617
"math/big"
1718
"runtime"
1819
"strings"
@@ -469,6 +470,9 @@ func testVerify(t *testing.T, test verifyTest, useSystemRoots bool) {
469470
chains, err := leaf.Verify(opts)
470471

471472
if test.errorCallback == nil && err != nil {
473+
if runtime.GOOS == "windows" && strings.HasSuffix(testenv.Builder(), "-2008") && err.Error() == "x509: certificate signed by unknown authority" {
474+
testenv.SkipFlaky(t, 19564)
475+
}
472476
t.Fatalf("unexpected error: %v", err)
473477
}
474478
if test.errorCallback != nil {

0 commit comments

Comments
 (0)