misc/wasm: check type of argument to Go.run

neelance · Richard Musiol · commit 7be8358f70ff · 2020-11-02T13:02:40.000Z
This results in a nicer error message if the argument to Go.run is omitted or of the wrong type. Fixes #37000 Change-Id: I7f36d007f41a79b2cea1cebf5cce127786341202 Reviewed-on: https://go-review.googlesource.com/c/go/+/266117 Trust: Richard Musiol <neelance@gmail.com> Run-TryBot: Richard Musiol <neelance@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
diff --git a/misc/wasm/wasm_exec.js b/misc/wasm/wasm_exec.js
@@ -503,6 +503,9 @@
 		}
 
 		async run(instance) {
+			if (!(instance instanceof WebAssembly.Instance)) {
+				throw new Error("Go.run: WebAssembly.Instance expected");
+			}
 			this._inst = instance;
 			this.mem = new DataView(this._inst.exports.mem.buffer);
 			this._values = [ // JS values that Go currently has references to, indexed by reference id

Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,9 @@`
`503`	`503`	`}`
`504`	`504`
`505`	`505`	`async run(instance) {`
	`506`	`+ if (!(instance instanceof WebAssembly.Instance)) {`
	`507`	`+ throw new Error("Go.run: WebAssembly.Instance expected");`
	`508`	`+ }`
`506`	`509`	`this._inst = instance;`
`507`	`510`	`this.mem = new DataView(this._inst.exports.mem.buffer);`
`508`	`511`	`this._values = [ // JS values that Go currently has references to, indexed by reference id`