cmd/pack: dump output of command of "go env" command in test

robpike · robpike · commit 8ac499916e2e · 2014-02-19T15:01:50.000-08:00
Get more information to help understand build failure on Plan 9. Also Windows. (TestHello is failing because GOCHAR does not appear in output. What does?) Update #7362 LGTM=bradfitz R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/66070044
diff --git a/src/cmd/pack/pack_test.go b/src/cmd/pack/pack_test.go
@@ -195,7 +195,7 @@ func TestHello(t *testing.T) {
 	out := run("go", "env")
 	i := strings.Index(out, "GOCHAR=\"")
 	if i < 0 {
-		t.Fatal("cannot find GOCHAR in 'go env' output")
+		t.Fatal("cannot find GOCHAR in 'go env' output:\n", out)
 	}
 	char := out[i+8 : i+9]
 	run("go", "build", "cmd/pack") // writes pack binary to dir

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func TestHello(t *testing.T) {`
`195`	`195`	`out := run("go", "env")`
`196`	`196`	`i := strings.Index(out, "GOCHAR=\"")`
`197`	`197`	`if i < 0 {`
`198`		`- t.Fatal("cannot find GOCHAR in 'go env' output")`
	`198`	`+ t.Fatal("cannot find GOCHAR in 'go env' output:\n", out)`
`199`	`199`	`}`
`200`	`200`	`char := out[i+8 : i+9]`
`201`	`201`	`run("go", "build", "cmd/pack") // writes pack binary to dir`