internal/lsp: fix panic in builtin completions

Fixes #38091

Change-Id: I88ac6d3413de3dd9d235e2f2fca9b4a3f7127e0a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227026
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Rohan Challa <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>

Author: stamblerre

internal/lsp/source/completion_builtin.go

@@ -59,6 +59,9 @@ func (c *completer) builtinArgType(obj types.Object, call *ast.CallExpr, parentI
 
 	switch obj.Name() {
 	case "append":
+		if parentInf.objType == nil {
+			break
+		}
 		inf.objType = parentInf.objType
 
 		// Check if we are completing the variadic append() param.

internal/lsp/testdata/lsp/primarymod/append/append.go

@@ -17,3 +17,4 @@ func _() {
 	// Don't add "..." to append() argument.
 	bar(append()) //@snippet("))", appendStrings, "aStrings", "aStrings")
 }
+}

internal/lsp/testdata/lsp/primarymod/append/append2.go.in

@@ -0,0 +1,5 @@
+package append
+
+func _() {
+	_ = append(a, struct) //@complete(")")
+}

internal/lsp/testdata/lsp/summary.txt.golden

@@ -1,6 +1,6 @@
 -- summary --
 CodeLensCount = 2
-CompletionsCount = 237
+CompletionsCount = 238
 CompletionSnippetCount = 75
 UnimportedCompletionsCount = 11
 DeepCompletionsCount = 5