cmd/link: disable flaky Darwin "symbols" test

dr2chase · dr2chase · commit aea1259a7288 · 2021-03-03T01:40:22.000Z
About one run out of 3 it fails on my laptop, and I am tired of having to be a nanny for my tests just because of this one flaky test. This has been a problem for months. Updates #32218. Change-Id: I2871d4c6f47e9432d189ed7bdcda8f9c0871cfc5 Reviewed-on: https://go-review.googlesource.com/c/go/+/297469 Trust: David Chase <drchase@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go
@@ -91,7 +91,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
 				exe = filepath.Join(tmpDir, "go.o")
 			}
 
-			if runtime.GOOS == "darwin" {
+			darwinSymbolTestIsTooFlaky := true // Turn this off, it is too flaky -- See #32218
+			if runtime.GOOS == "darwin" && !darwinSymbolTestIsTooFlaky {
 				if _, err = exec.LookPath("symbols"); err == nil {
 					// Ensure Apple's tooling can parse our object for symbols.
 					out, err = exec.Command("symbols", exe).CombinedOutput()

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)`
`91`	`91`	`exe = filepath.Join(tmpDir, "go.o")`
`92`	`92`	`}`
`93`	`93`
`94`		`- if runtime.GOOS == "darwin" {`
	`94`	`+ darwinSymbolTestIsTooFlaky := true // Turn this off, it is too flaky -- See #32218`
	`95`	`+ if runtime.GOOS == "darwin" && !darwinSymbolTestIsTooFlaky {`
`95`	`96`	`if _, err = exec.LookPath("symbols"); err == nil {`
`96`	`97`	`// Ensure Apple's tooling can parse our object for symbols.`
`97`	`98`	`out, err = exec.Command("symbols", exe).CombinedOutput()`