fix review issues

ZekeLu · ZekeLu · commit aeb70ca8a08e · 2022-09-15T11:50:28.000+08:00
diff --git a/src/debug/elf/file.go b/src/debug/elf/file.go
@@ -481,7 +481,7 @@ func NewFile(r io.ReaderAt) (*File, error) {
 	}
 	shstr := f.Sections[shstrndx]
 	if shstr.Type != SHT_STRTAB {
-		return nil, &FormatError{0, "invalid (pointing to non SHT_STRTAB section) ELF shstrndx", shstrndx}
+		return nil, &FormatError{shoff + int64(shstrndx*shentsize), "invalid ELF section name string table type", shstr.Type}
 	}
 	shstrtab, err := shstr.Data()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ func NewFile(r io.ReaderAt) (*File, error) {`
`481`	`481`	`}`
`482`	`482`	`shstr := f.Sections[shstrndx]`
`483`	`483`	`if shstr.Type != SHT_STRTAB {`
`484`		`- return nil, &FormatError{0, "invalid (pointing to non SHT_STRTAB section) ELF shstrndx", shstrndx}`
	`484`	`+ return nil, &FormatError{shoff + int64(shstrndx*shentsize), "invalid ELF section name string table type", shstr.Type}`
`485`	`485`	`}`
`486`	`486`	`shstrtab, err := shstr.Data()`
`487`	`487`	`if err != nil {`