cmd/compile: add OMOD to list of ops that might panic

josharian · josharian · commit ca5cea9dca0b · 2016-11-03T06:09:52.000Z
Follow-up to CL 32551. Change-Id: If68f9581a7f13e04796aaff2007c09f8ea2c3611 Reviewed-on: https://go-review.googlesource.com/32586 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
diff --git a/src/cmd/compile/internal/gc/subr.go b/src/cmd/compile/internal/gc/subr.go
@@ -1183,7 +1183,7 @@ func ullmancalc(n *Node) {
 			goto out
 		}
 	case OINDEX, OSLICE, OSLICEARR, OSLICE3, OSLICE3ARR, OSLICESTR,
-		OIND, ODOTPTR, ODOTTYPE, ODIV:
+		OIND, ODOTPTR, ODOTTYPE, ODIV, OMOD:
 		// These ops might panic, make sure they are done
 		// before we start marshaling args for a call. See issue 16760.
 		ul = UINF

Original file line number	Diff line number	Diff line change
`@@ -1183,7 +1183,7 @@ func ullmancalc(n *Node) {`
`1183`	`1183`	`goto out`
`1184`	`1184`	`}`
`1185`	`1185`	`case OINDEX, OSLICE, OSLICEARR, OSLICE3, OSLICE3ARR, OSLICESTR,`
`1186`		`- OIND, ODOTPTR, ODOTTYPE, ODIV:`
	`1186`	`+ OIND, ODOTPTR, ODOTTYPE, ODIV, OMOD:`
`1187`	`1187`	`// These ops might panic, make sure they are done`
`1188`	`1188`	`// before we start marshaling args for a call. See issue 16760.`
`1189`	`1189`	`ul = UINF`