Skip to content

Commit d1180db

Browse files
rscgopherbot
authored andcommitted
runtime: relax TestWindowsStackMemory from 100kB to 128kB
We've been getting intermittent flakes in this test since 2023, all reporting values just barely over 100kB on windows-386. If we were happy with 100kB, we should be happy with 128kB, and it should fix the flakes. Fixes #58570. Change-Id: Iabe734cfbba6fe28a83f62e7811ee03fed424f0b Reviewed-on: https://go-review.googlesource.com/c/go/+/628795 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Russ Cox <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
1 parent 01e1e5c commit d1180db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/runtime/syscall_windows_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ func TestWindowsStackMemory(t *testing.T) {
673673
if err != nil {
674674
t.Fatalf("Failed to read stack usage: %v", err)
675675
}
676-
if expected, got := 100<<10, stackUsage; got > expected {
676+
if expected, got := 128<<10, stackUsage; got > expected {
677677
t.Fatalf("expected < %d bytes of memory per thread, got %d", expected, got)
678678
}
679679
}

0 commit comments

Comments
 (0)