cmd/go: parse dot-separated identifiers in build metadata

mellis · Bryan C. Mills · commit dcb1363a1fc3 · 2018-11-19T20:34:23.000Z
Per https://semver.org/#spec-item-10, build metadata may include a series of dot separated identifiers. Fixes #28647 Change-Id: I98655c62584a822953df71fba32b4a2cafe7a04b Reviewed-on: https://go-review.googlesource.com/c/148835 Reviewed-by: Bryan C. Mills <bcmills@google.com>
diff --git a/src/cmd/go/internal/semver/semver.go b/src/cmd/go/internal/semver/semver.go
@@ -263,7 +263,7 @@ func parseBuild(v string) (t, rest string, ok bool) {
 	i := 1
 	start := 1
 	for i < len(v) {
-		if !isIdentChar(v[i]) {
+		if !isIdentChar(v[i]) && v[i] != '.' {
 			return
 		}
 		if v[i] == '.' {
diff --git a/src/cmd/go/internal/semver/semver_test.go b/src/cmd/go/internal/semver/semver_test.go
@@ -44,6 +44,7 @@ var tests = []struct {
 	{"v1.2.3", "v1.2.3"},
 	{"v1.2.3+meta", "v1.2.3"},
 	{"v1.2.3+meta-pre", "v1.2.3"},
+	{"v1.2.3+meta-pre.sha.256a", "v1.2.3"},
 }
 
 func TestIsValid(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ func parseBuild(v string) (t, rest string, ok bool) {`
`263`	`263`	`i := 1`
`264`	`264`	`start := 1`
`265`	`265`	`for i < len(v) {`
`266`		`- if !isIdentChar(v[i]) {`
	`266`	`+ if !isIdentChar(v[i]) && v[i] != '.' {`
`267`	`267`	`return`
`268`	`268`	`}`
`269`	`269`	`if v[i] == '.' {`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ var tests = []struct {`
`44`	`44`	`{"v1.2.3", "v1.2.3"},`
`45`	`45`	`{"v1.2.3+meta", "v1.2.3"},`
`46`	`46`	`{"v1.2.3+meta-pre", "v1.2.3"},`
	`47`	`+ {"v1.2.3+meta-pre.sha.256a", "v1.2.3"},`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`func TestIsValid(t *testing.T) {`