Skip to content

Commit dcd1c31

Browse files
author
Bryan C. Mills
committed
runtime: skip TestSegv/SegvInCgo earlier on ios
It appears to sometimes hang instead of crashing, which can cause subsequent tests to time out. For #59947. Change-Id: Id4ac3c0cd5f7f345334d3e0ed3f48e40b9ff191c Reviewed-on: https://go-review.googlesource.com/c/go/+/492075 TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Bryan Mills <[email protected]>
1 parent ca49b8d commit dcd1c31

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/runtime/crash_cgo_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,10 @@ func TestSegv(t *testing.T) {
643643
}
644644

645645
t.Run(test, func(t *testing.T) {
646+
if test == "SegvInCgo" && runtime.GOOS == "ios" {
647+
testenv.SkipFlaky(t, 59947) // Don't even try, in case it times out.
648+
}
649+
646650
t.Parallel()
647651
got := runTestProg(t, "testprogcgo", test)
648652
t.Log(got)

0 commit comments

Comments
 (0)