Skip to content

Commit f0390ff

Browse files
author
Bryan C. Mills
committed
cmd/go/internal/modfetch: remove non-hermetic test
The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 8550a58 commit f0390ff

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/cmd/go/internal/modfetch/coderepo_test.go

-12
Original file line numberDiff line numberDiff line change
@@ -368,18 +368,6 @@ var codeRepoTests = []codeRepoTest{
368368
zipSum: "h1:829vOVxxusYHC+IqBtkX5mbKtsY9fheQiQn0MZRVLfQ=",
369369
zipFileHash: "9e7cb3f4f1e66d722306442b0dbe1f6f43d74d1736d54c510537bdfb1d6f432f",
370370
},
371-
{
372-
vcs: "git",
373-
path: "gopkg.in/yaml.v2",
374-
rev: "v2",
375-
version: "v2.2.5-0.20191002202810-970885f01c8b",
376-
name: "970885f01c8bc1fecb7ab1c8ce8e7609bda45530",
377-
short: "970885f01c8b",
378-
time: time.Date(2019, 10, 2, 20, 28, 10, 0, time.UTC),
379-
gomod: "module \"gopkg.in/yaml.v2\"\n\nrequire (\n\t\"gopkg.in/check.v1\" v0.0.0-20161208181325-20d25e280405\n)\n",
380-
zipSum: "h1:c7zdkYUaqShimBvZzvhOA+Absl0aDaGKX267vSm0Z7E=",
381-
zipFileHash: "5856a108e1aa8ec9c35f4479f8e806652b326b648c80abd08fc403707f4eb5f1",
382-
},
383371
{
384372
vcs: "git",
385373
path: "vcs-test.golang.org/go/mod/gitrepo1",

0 commit comments

Comments
 (0)