Skip to content

Commit f4b9183

Browse files
committed
test: enable fixedbugs/bug193.go for -G compiler option
Temporarily disable a questionable test case in fixedbugs/bug193.go and enable the test as a whole. See the issues below for details. Updates #45114. Updates #45117. Change-Id: I1de6f8d79b592eeeec139cd92b6c9cac56a9a74b Reviewed-on: https://go-review.googlesource.com/c/go/+/303094 Trust: Robert Griesemer <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
1 parent cd26192 commit f4b9183

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/fixedbugs/bug193.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ func main() {
1111
ss := 1 << s
1212
y1 := float64(ss)
1313
y2 := float64(1 << s) // ERROR "shift"
14-
y3 := string(1 << s) // ERROR "shift"
14+
// see issues #45114, #45117
15+
// y3 := string(1 << s) // DISABLED "shift"
16+
y3 := 0
1517
_, _, _, _, _ = s, ss, y1, y2, y3
1618
}

test/run.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1939,7 +1939,6 @@ var excluded = map[string]bool{
19391939
"writebarrier.go": true, // correct diagnostics, but different lines (probably irgen's fault)
19401940

19411941
"fixedbugs/bug176.go": true, // types2 reports all errors (pref: types2)
1942-
"fixedbugs/bug193.go": true, // types2 bug: shift error not reported (fixed in go/types)
19431942
"fixedbugs/bug195.go": true, // types2 reports slightly different (but correct) bugs
19441943
"fixedbugs/bug228.go": true, // types2 not run after syntax errors
19451944
"fixedbugs/bug231.go": true, // types2 bug? (same error reported twice)

0 commit comments

Comments
 (0)