Skip to content

Commit f8dc4f2

Browse files
josharianbradfitz
authored andcommitted
Revert "cmd/vet: ignore printf failures in cmd"
This reverts commit f15915a. CL 32851 fixed cmd/vet's handling of fmt.Formatter. Updates #17057. Change-Id: I3409100d16037645946fe7fe78fbb173e1648494 Reviewed-on: https://go-review.googlesource.com/33166 Run-TryBot: Josh Bleecher Snyder <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 7c9f910 commit f8dc4f2

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/cmd/vet/all/main.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -265,15 +265,6 @@ NextLine:
265265
}
266266
}
267267

268-
// Temporarily ignore unrecognized printf verbs from cmd.
269-
// The compiler now has several fancy verbs (CL 28339)
270-
// used with types implementing fmt.Formatters,
271-
// and I believe gri has plans to add many more.
272-
// TODO: remove when issue 17057 is fixed.
273-
if strings.HasPrefix(file, "cmd/") && strings.HasPrefix(msg, "unrecognized printf verb") {
274-
continue
275-
}
276-
277268
key := file + ": " + msg
278269
if w[key] == 0 {
279270
// Vet error with no match in the whitelist. Print it.

0 commit comments

Comments
 (0)