Skip to content

net: TestDialerFallbackDelay fails when no external IPv6 connectivity #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikioh opened this issue Mar 9, 2016 · 2 comments
Closed

net: TestDialerFallbackDelay fails when no external IPv6 connectivity #14731

mikioh opened this issue Mar 9, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@mikioh
Copy link
Contributor

mikioh commented Mar 9, 2016

For example,

go test -v -run=TestDialerFallbackDelay
--- FAIL: TestDialerFallbackDelay (0.00s)
    dial_test.go:477: #1: got 378.549µs; want >= 199ms
    dial_test.go:477: #2: got 440.764µs; want >= 299ms
FAIL

Looks like it requires -ipv6 flag.
@mikioh mikioh added this to the Go1.7 milestone Mar 9, 2016
@pmarks-net
Copy link
Contributor

I see the problem. slowDialTCP interprets a zero deadline as "don't wait", rather than "wait forever".

You can reproduce the bug on a dual-stack Linux machine by running:

$ sudo ip -6 route add unreachable 2001:2::254
$ ../bin/go test -v net -run TestDialerFallbackDelay

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20493 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
3 participants
@mikioh @pmarks-net @gopherbot