Skip to content

go/build: permit vendoring golang.org from std without breaking users #17326

Closed
@bradfitz

Description

@bradfitz

In #16333 a user reported that they were unable to vendor code which the Go standard library itself vendored.

To "fix" the problem for the 1.7 release, we renamed the "$GOROOT/src/vendor/golang.org" directory to "golang_org" with an underscore, so it wouldn't conflict with users.

This is slightly annoying for us to maintain in the stdlib.

We should probably fix it properly in go/build and/or cmd/go.

/cc @ianlancetaylor @rsc

Activity

added this to the Go1.8 milestone on Oct 3, 2016
added
NeedsFixThe path to resolution is known, but the work has not been done.
on Oct 7, 2016
modified the milestones: Go1.9Early, Go1.8 on Oct 26, 2016
added
early-in-cycleA change that should be done early in the 3 month dev cycle.
and removed
early-in-cycleA change that should be done early in the 3 month dev cycle.
on Jun 14, 2017
modified the milestones: Go1.10Early, Go1.10 on Jun 14, 2017

14 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.early-in-cycleA change that should be done early in the 3 month dev cycle.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bradfitz@rsc@quentinmit@ianlancetaylor@gopherbot

        Issue actions

          go/build: permit vendoring golang.org from std without breaking users · Issue #17326 · golang/go