Skip to content

README.md: outdated install instructions, GOROOT setting is too prominent #18675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ALTree opened this issue Jan 16, 2017 · 4 comments
Closed

README.md: outdated install instructions, GOROOT setting is too prominent #18675

ALTree opened this issue Jan 16, 2017 · 4 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@ALTree
Copy link
Member

ALTree commented Jan 16, 2017 •
edited
Loading

CL c497c9e updated the installation instructions in doc/install.html to clarify that GOROOT should only be set when using a custom install path. This fixed #6613 (doc: clarify that GOROOT is only necessary for non-standard install locations), but the README.md file (the one you see when you visit github.com/golang/go) was not updated, and the Binary distribution section still starts like this:

If you have just untarred a binary Go distribution, you need to set the environment variable $GOROOT

which is not ideal.
@ALTree ALTree added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 16, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/35183 mentions this issue.

@minux
Copy link
Member

minux commented Jan 17, 2017 via email

@minux minux added this to the Go1.8 milestone Jan 17, 2017
@kardianos
Copy link
Contributor

@minux Only if you require the go exec to live in the GOROOT, which is different then today.

@minux
Copy link
Member

minux commented Jan 17, 2017 via email

@golang golang locked and limited conversation to collaborators Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@minux @kardianos @ALTree @gopherbot