-
Notifications
You must be signed in to change notification settings - Fork 18k
spec: no mention of "factored" import statements #24011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's an import block. |
That sounds more familiar to me, thanks - forgot to mention it in the issue. The spec doesn't explicitly mention it either, though. Should the tour page be updated to mention import blocks instead? |
I think the tour is pretty clear: First of all the term factored is in double quotes in the tour, making it clear that it's not really a formal term, but it also explains what it is: The In any case, this is not an issue with the spec. If @josharian likes to use the term but doesn't define it enough, perhaps you should take it up with him? Closing. |
Sorry to have caused confusion. I was on my phone and used the first word that sprang to mind to describe them. |
@josharian just mentioned them in #23966 (comment):
I have no idea what it means. The only somewhat-official link I could find via google is https://tour.golang.org/basics/2:
I can understand if the term "factored" doesn't belong in a formal spec. However, if that is a name that people tend to use for it - and given how the Go spec tries to be helpful with examples and notes for newcomers - I think it would be a good addition.
On the other hand, if this term should be avoided, it should be removed from the tour. In that case, I'd be curious to know how to call them. I assume "grouped imports" isn't an option, as that refers to imports within parentheses that have no empty lines in between them.
/cc @griesemer
The text was updated successfully, but these errors were encountered: