Skip to content

crypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FiloSottile opened this issue Jan 17, 2019 · 2 comments
Closed

crypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793

FiloSottile opened this issue Jan 17, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@FiloSottile
Copy link
Contributor

A (weird, non-Go) client that prefers PSSWithSHA512 (minimum key size 1040 bits) but supports PSSWithSHA256 (minimum key size 528 bits) would fail to connect to a Go server with a certificate with a 1024 bit key.

We should refuse to negotiate parameters that we already know are not supported by the certificate key.

See #29779 (comment)
@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 17, 2019
@FiloSottile FiloSottile added this to the Go1.13 milestone Jan 17, 2019
@FiloSottile FiloSottile self-assigned this Jan 17, 2019
@FiloSottile FiloSottile mentioned this issue Jan 17, 2019
Closed
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@FiloSottile
Copy link
Contributor Author

FiloSottile commented Jul 22, 2019 •
edited
Loading

This makes sense to tackle along with #32426 and #28660, as well as with updating the certificate selection logic.

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@FiloSottile FiloSottile modified the milestones: Backlog, Go1.14 Oct 23, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/205177 mentions this issue: crypto/tls: take key size into account in signature algorithm selection

@golang golang locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@rsc @andybons @FiloSottile @gopherbot