Skip to content

misc/cgo/test: make sure we run TestCrossPackageTests with appropriate options #31083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianlancetaylor opened this issue Mar 27, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

In https://golang.org/cl/163418 we started running several of the tests in misc/cgo/test via a separate invocation of go test. In cmd/dist we run the tests in misc/cgo/test with several different -linkmode options; see (*tester).cgoTest in cmd/dist/test.go. But as far as I can see those different options are not being carried through the separate invocation of go test in TestCrossPackageTests, so we are no longer testing all the cases we did before.

This issue is to make sure that we run those tests with the appropriate options.

CC @bcmills

@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 27, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.13 milestone Mar 27, 2019
@bcmills
Copy link
Contributor

bcmills commented Mar 27, 2019

TestCrossPackageTests explicitly propagates os.Environ(), so it would probably suffice for cmd/dist to set whatever options are needed in the GOFLAGS variable before running the test.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/169779 mentions this issue: cmd/dist: pass cgotest linkmode via GOFLAGS

@golang golang locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants