x/tools/gopls: sudden errors in unrelated files

[atombender]

What did you do?

Edited code in a single test file in VSCode.

What did you expect to see?

Only my current file should be affected by changes in a test package.

What did you see instead?

Suddenly, a large number of unrelated files were marked as having errors. I did not have any of these files open, nor did I change them, nor did (as far as I know) any program on my computer touch them. All the errors in them are spurious; restarting gopls causes them to go away.

Log: gopls.log.gz. This is from gopls started, so fairly large. Jump to line 14890 to see what looks like the first error.

Note: While I have GOFLAGS=-tags=... set, none of the affected files use build tags.

Build info

golang.org/x/tools/gopls master
    golang.org/x/tools/gopls@(devel)
    github.com/BurntSushi/[email protected] h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/sergi/[email protected] h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/[email protected] h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
    golang.org/x/[email protected] h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
    golang.org/x/[email protected] => ../
    golang.org/x/[email protected] h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
    honnef.co/go/[email protected] h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=
    mvdan.cc/xurls/[email protected] h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=

Go info

go version go1.13.10 darwin/amd64

[gopherbot]

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

[stamblerre]

Thanks for the report. This looks like #38403, which is unfortunate because I had hoped that it was only caused by -remote.

Did any of the files with errors depend transitively on the readthrough package?

[atombender]

Yes, but not all. Also, my last edit to anything in the readthrough package was two minutes before this happened. I mostly edited the readthrough_test package.

You guys really don't like capitalized sentences in issue titles. 🙂

[stamblerre]

Yes, but not all. Also, my last edit to anything in the readthrough package was two minutes before this happened. I mostly edited the readthrough_test package.

Thanks for clarifying. Tests can still be dependencies (if this is an in-package test, and not an x_test) because other test packages depend on test variants. It's possible that we have another cache invalidation issue with test variants, but I'm not sure how that could've happened since it's been a while since the type-checking code has changed.

I think I will close this issue as a duplicate of #38403 so that we can track everything in one place. Please comment there if you're able to find a consistent repro for this.

You guys really don't like capitalized sentences in issue titles. 🙂

We tend to follow the same style in issues and commit messages - see https://github.com/golang/go/wiki/CommitMessage.

[stamblerre]

Duplicate of #38403