Skip to content

runtime: map insertion should overwrite existing keys #45045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
randall77 opened this issue Mar 16, 2021 · 4 comments
Closed

runtime: map insertion should overwrite existing keys #45045

randall77 opened this issue Mar 16, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@randall77
Copy link
Contributor

Looks like this happens correctly in mapassign, but not in the mapassign_faststr variant.

@mdempsky

First noticed as part of #45021
@randall77 randall77 added this to the Go1.17 milestone Mar 16, 2021
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 16, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/305089 mentions this issue: runtime: overwrite existing keys for mapassign_faststr variant

@networkimprov
Copy link

Backport candidate?

@cuonglm
Copy link
Member

cuonglm commented Mar 28, 2021

Backport candidate?

I don't think this can be qualified for backport.

@randall77
Copy link
Contributor Author

I agree. This is not a serious enough problem to warrant a backport.

https://github.com/golang/go/wiki/MinorReleases

A “serious” problem is one that prevents a program from working at all.

@golang golang locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
5 participants
@networkimprov @cuonglm @randall77 @gopherbot @cherrymui