x/tools/gopls: evaluate hex/binary integer literals when mousing over

[soypat]

What version of Go are you using (go version)?

$ gopls version
golang.org/x/tools/gopls v0.6.10
    golang.org/x/tools/[email protected] h1:8Ebz8PymS2umcuCFhoz67unyJfWsipjTIrkBUF9kypg=

$ VsCode settings:
 "gopls": {	
        "ui.semanticTokens": true,
	},
    "editor.semanticHighlighting.enabled": true,

What did you do?

Mouse over a hex/binary notation integer

var (

    hex = 0xe34e
    bigBin = 0b1001001
    x = hex*0b1101
)

What did you expect to see?

Gopls evaluate the number in decimal form and show me the result (I'm in VSCode). Gopls does this for const identifiers and it is super helpful!

What did you see instead?

Nothing

[danishprakash]

I'd like to work on this cc: @stamblerre

[stamblerre]

@danishprakash: Sounds good! Let me know if you need any guidance.

[danishprakash]

@stamblerre I tried dabbling with this and have pushed my changes here https://github.com/golang/tools/compare/master...danishprakash:hover-evaluate-hex?expand=1. Let me know if that approach sounds good, I'll raise a pull request.

[stamblerre]

Thanks for working on that @danishprakash! It does look like the right approach so feel free to send a PR.

[danishprakash]

Posting the PR link here https://go-review.googlesource.com/c/tools/+/330309, not sure if the bot would backlink this. (ideally we should)

[gopherbot]

Change https://golang.org/cl/330309 mentions this issue: internal/lsp/source: evaluate bin/hex literal on hover