Skip to content

go.exp/fsnotify: shouldn't export linux-specific consts #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Apr 7, 2013 · 9 comments
Closed

go.exp/fsnotify: shouldn't export linux-specific consts #5234

gopherbot opened this issue Apr 7, 2013 · 9 comments

Comments

@gopherbot
Copy link
Contributor

fsnotify, the cross-platform file notification api, currently exports linux-specific
consts (when on linux):

http://godoc.org/code.google.com/p/go.exp/fsnotify

e.g. the only mentions of IN_DELETE_SELF are in fsnotify_linux.go. The IN_* and related
consts should not be exported. Perhaps just import syscall with a shorter name to make
sy.IN_DELETE_SELF short enough to type.

This is go.exp at 29:faab6deef005.
@dsymonds
Copy link
Contributor

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented May 24, 2013

Comment 2:

The whole API needs to be made more OS-neutral.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 3:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-exp.

@nathany
Copy link
Contributor

nathany commented Jan 30, 2014

@nathany
Copy link
Contributor

nathany commented Jun 29, 2014

Comment 8:

Can this issue be closed?

@gopherbot
Copy link
Contributor Author

Comment 9:

Looks done to me. I am the original reporter.

@minux
Copy link
Member

minux commented Jun 29, 2014

Comment 10:

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants