encoding/json: fix using omitempty in combination with MarshalJSON #53425
+35
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
omitempty
option does not support objects with aMarshalJSON
function.This means that a field annotated with the
omitempty
tag can still contain anull
,0
,false
,""
or[]
value and will never be omitted.This PR fixes this issue: if the
MarshalJSON
function returns an empty value, that value is omitted.See #45669 (comment) for more background information.