Skip to content

x/tools/gopls: strange results for references to unified.String #59805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Apr 24, 2023 · 1 comment
Closed

x/tools/gopls: strange results for references to unified.String #59805

findleyr opened this issue Apr 24, 2023 · 1 comment
Assignees
@adonovan
Labels
FrozenDueToAge gopls/incremental gopls Issues related to the Go language server, gopls. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Member

Reported by @pjweinb in chat: finding references to x/tools/internal/diff.unified.String returns several results that don't quite make sense. I would expect these to include references to (unified).String as well as any references to the interface method fmt.Stringer.String, but I would not expect any references to the String method of other concrete types.

Since we haven't yet filtered to workspace packages (#59674), I see some strange results in std. For example, I see a reference to (strings.Builder).String inside the (*expvar.Map).String) method. But surprisingly, I don't see a reference to the (*expvar.Map).String) method itself!

Something is amiss.
@findleyr findleyr added release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Apr 24, 2023
@findleyr findleyr added this to the gopls/v0.12.0 milestone Apr 24, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 24, 2023
@findleyr findleyr changed the title x/tools/gopls: strange results for references unified.String x/tools/gopls: strange results for references to unified.String May 1, 2023
@adonovan
Copy link
Member

adonovan commented May 9, 2023

Dup of #59674 (scope too large) in conjunction with #59851 (expansions repeatedly applied from concrete to interface types and back). I have verified that it was fixed by https://go.dev/cl/487017.

@adonovan adonovan closed this as completed May 9, 2023
@golang golang locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
FrozenDueToAge gopls/incremental gopls Issues related to the Go language server, gopls. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr