Skip to content

runtime: TestWindowsStackMemory flakes on windows-386-2016 [1.20 backport] #61055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 28, 2023 · 3 comments
Closed

runtime: TestWindowsStackMemory flakes on windows-386-2016 [1.20 backport] #61055

gopherbot opened this issue Jun 28, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.20.6

Comments

@gopherbot
Copy link
Contributor

@mknyszek requested issue #58570 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport issues for Go 1.19 and Go 1.20.

This is a test-only fix that is very small and very safe.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 28, 2023
@gopherbot gopherbot mentioned this issue Jun 28, 2023
Open
@mknyszek mknyszek modified the milestones: Go1.19.11, Go1.20.6 Jun 28, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 28, 2023
@mknyszek
Copy link
Contributor

This already landed as https://go.dev/cl/506975. (Sorry about that!)

@mknyszek mknyszek added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 28, 2023
@mknyszek
Copy link
Contributor

If this is approved, please feel free to just close it. Otherwise, please send me the revert and I'll +2. Thanks.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 28, 2023
@dmitshur
Copy link
Member

No problem, thanks for improving test health on the release branch!

Closed by merging 08a58dd to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot